From: Leon Romanovsky [mailto:l...@kernel.org] Sent: Thursday, May 31, 2018 8:33 PM > On Wed, May 30, 2018 at 04:11:37PM +0300, Yuval Bason wrote: > > This patch adds support for configuring SRQ and provides the necessary > > APIs for rdma upper layer driver (qedr) to enable the SRQ feature. > > > > Signed-off-by: Michal Kalderon <michal.kalde...@cavium.com> > > Signed-off-by: Ariel Elior <ariel.el...@cavium.com> > > Signed-off-by: Yuval Bason <yuval.ba...@cavium.com> > > --- > > drivers/net/ethernet/qlogic/qed/qed_cxt.c | 5 +- > > drivers/net/ethernet/qlogic/qed/qed_cxt.h | 1 + > > drivers/net/ethernet/qlogic/qed/qed_hsi.h | 2 + > > drivers/net/ethernet/qlogic/qed/qed_iwarp.c | 23 ++++ > > drivers/net/ethernet/qlogic/qed/qed_main.c | 2 + > > drivers/net/ethernet/qlogic/qed/qed_rdma.c | 179 > +++++++++++++++++++++++++++- > > drivers/net/ethernet/qlogic/qed/qed_rdma.h | 2 + > > drivers/net/ethernet/qlogic/qed/qed_roce.c | 17 ++- > > include/linux/qed/qed_rdma_if.h | 12 +- > > 9 files changed, 235 insertions(+), 8 deletions(-) > > > > ... > > > + struct qed_sp_init_data init_data; > > ... > > > + memset(&init_data, 0, sizeof(init_data)); > > This patter is so common in this patch, why? > > "struct qed_sp_init_data init_data = {};" will do the trick. > Thanks for pointing out, will be fixed in v2.
> Thanks
