From: Heiner Kallweit <hkallwe...@gmail.com> Date: Wed, 30 May 2018 22:13:20 +0200
> We can bail out immediately also in case of PHY_IGNORE_INTERRUPT because > phy_mac_interupt() informs us once the link is up. > > Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> When state is PHY_NOLINK, the phy_mac_interrupt() code paths will change the state to PHY_CHANGELINK before queueing up the state machine invocation. So I can't even see how we can enter phy_state_machine with ->state == PHY_NOLINK is the mac interrupt paths are being used properly. Therefore it looks like the code as written is harmless. Did you actually hit a problem with this test or is this a change based purely upon code inspection?
