We forgot to set the error code on this path.  This function is supposed
to return error pointers, so with this bug it accidentally returns NULL
and the caller doesn't check for that.

Fixes: cfc80d9a1163 ("net: Introduce net_failover driver")
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>

diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c
index ef50158e90a9..881f3fa13e6b 100644
--- a/drivers/net/net_failover.c
+++ b/drivers/net/net_failover.c
@@ -761,8 +761,10 @@ struct failover *net_failover_create(struct net_device 
*standby_dev)
        netif_carrier_off(failover_dev);
 
        failover = failover_register(failover_dev, &net_failover_ops);
-       if (IS_ERR(failover))
+       if (IS_ERR(failover)) {
+               err = PTR_ERR(failover);
                goto err_failover_register;
+       }
 
        return failover;
 

Reply via email to