On 2018/05/30 15:16, Elad Nachman wrote: > Interesting question. That's the way the driver was originally written and I > tried to minimize the changes in the patch. > Anyway, common.h (included by stmmac_main.c) contains the following: > > #if IS_ENABLED(CONFIG_VLAN_8021Q) > #define STMMAC_VLAN_TAG_USED > #include <linux/if_vlan.h> > #endif > > So the define in question kicks in only once you enable 802.1Q support in the > kernel .config .
So, we end up with stripping vlan even though the device does not have HW_VLAN_CTAG/STAG_RX when CONFIG_VLAN_8021Q is disabled, since the patch anyway removed the original condition... -- Toshiaki Makita
