On 05/25/2018 06:23 PM, Alexei Starovoitov wrote: > On Fri, May 25, 2018 at 12:20:36PM +0100, Mathieu Xhonneux wrote: >> Previous patch "selftests/bpf: test for seg6local End.BPF action" lacks >> some UAPI headers in tools/. >> >> clang -I. -I./include/uapi -I../../../include/uapi -idirafter >> /usr/local/include -idirafter >> /data/users/yhs/work/llvm/build/install/lib/clang/7.0.0/include >> -idirafter /usr/include -Wno-compare-distinct-pointer-types \ >> -O2 -target bpf -emit-llvm -c test_lwt_seg6local.c -o - | \ >> llc -march=bpf -mcpu=generic -filetype=obj -o >> [...]/net-next/tools/testing/selftests/bpf/test_lwt_seg6local.o >> test_lwt_seg6local.c:4:10: fatal error: 'linux/seg6_local.h' file not found >> ^~~~~~~~~~~~~~~~~~~~ >> 1 error generated. >> make: Leaving directory >> `/data/users/yhs/work/net-next/tools/testing/selftests/bpf' >> >> Reported-by: Y Song <ys114...@gmail.com> >> Signed-off-by: Mathieu Xhonneux <m.xhonn...@gmail.com> >> --- >> .../selftests/bpf/include/uapi/linux/seg6.h | 55 +++++++++++++++ >> .../selftests/bpf/include/uapi/linux/seg6_local.h | 80 >> ++++++++++++++++++++++ >> 2 files changed, 135 insertions(+) >> create mode 100644 tools/testing/selftests/bpf/include/uapi/linux/seg6.h >> create mode 100644 >> tools/testing/selftests/bpf/include/uapi/linux/seg6_local.h >> >> diff --git a/tools/testing/selftests/bpf/include/uapi/linux/seg6.h >> b/tools/testing/selftests/bpf/include/uapi/linux/seg6.h > > hmm. why to selftest? > Shouldn't they be added to tools/include/uapi/linux/ instead?
Yes, should definitely go there to tools include infrastructure.
