> -----Original Message----- > From: David Miller <[email protected]> > Sent: Tuesday, May 22, 2018 12:34 PM > To: Shaikh, Shahed <[email protected]> > Cc: [email protected]; Elior, Ariel <[email protected]>; Dept-Eng > Everest Linux L2 <[email protected]> > Subject: Re: [PATCH net 1/1] qed: Fix mask for physical address in ILT entry > > From: Shahed Shaikh <[email protected]> > Date: Mon, 21 May 2018 12:31:47 -0700 > > > ILT entry requires 12 bit right shifted physical address. > > Existing mask for ILT entry of physical address i.e. > > ILT_ENTRY_PHY_ADDR_MASK is not sufficient to handle 64bit address > > because upper 8 bits of 64 bit address were getting masked which > > resulted in completer abort error on PCIe bus due to invalid address. > > > > Fix that mask to handle 64bit physical address. > > > > Fixes: fe56b9e6a8d9 ("qed: Add module with basic common support") > > > > Signed-off-by: Shahed Shaikh <[email protected]> > > Signed-off-by: Ariel Elior <[email protected]> > > Please do not put an empty line between Fixes: and other tags in the future. > I > fixed it up this time.
Sorry about this. Thanks for fixing. > > Applied, thanks. Can you please queues this fix for -stable? Thanks, Shahed
