On 05/18/2018 02:37 PM, Pavel Tatashin wrote:

>       * parallelized this function, so drop lock for the
>>
>>     Parallelizing? Else the sentence doesn't parse for me. :-)

   My comment hardly makes sense when you removed all the context...

> Hi Sergei,
> 
> In a separate series I parallelized device_shutdown(), see:
> http://lkml.kernel.org/r/20180516024004.28977-1-pasha.tatas...@oracle.com
> 
> But, this particular patch should be dropped, as discussed in this thread:
> http://lkml.kernel.org/r/20180503035931.22439-2-pasha.tatas...@oracle.com
> 
> 
> Alexander Duyck, made a point that a generic RTNL scalability fix should be 
> done. This particular patch might introduce a race, since it relies on 
> assumption that RTNL is not needed in this place because  ixgbe_close() does 
> not have it, but Alexander Duyck, says that the callers of ixgbe_close() are 
> assumed to own this lock.

   My comment was about the English grammar only. :-)

> Thank you,
> Pavel

MBR, Sergei

Reply via email to