On Mon, Oct 02, 2006 at 06:50:39PM +0200, Arnd Bergmann wrote: > On Monday 02 October 2006 18:27, Linas Vepstas wrote: > > > > > > I'm not sure if I have missed a patch in here, but I > > > don't see anything reintroducing the 'netif_stop_queue' > > > that is missing from the transmit path. > > > > > > Do you have a extra patch for that? > > > > Unfinished. There are several ways in which the current > > spider-net driver doesn't do things the way Greg KH's, etal > > book on device drivers recommends. I was planning on combing > > through these this week. > > Ok, that's good. However, removing the netif_stop_queue > was an obvious oversight that happened during the cleanup > last year. > > Putting that one line back in should be a really safe fix for > the problem of overly high system load we sometimes see.
Hmm. I have a patch from 5 weeks ago that seems to insert a bunch of these. I'm not sure why it hadn't been mailed before, I'll test and post as soon as I can. --linas - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html