On Mon, May 14, 2018 at 5:11 PM, Alexei Starovoitov <a...@kernel.org> wrote: > --build-id may not be a default linker config. > Make sure it's used when linking urandom_read test program. > Otherwise test_stacktrace_build_id[_nmi] tests will be failling. > > Signed-off-by: Alexei Starovoitov <a...@kernel.org>
Tested and the change looks good. Acked-by: Yonghong Song <y...@fb.com> > --- > tools/testing/selftests/bpf/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/Makefile > b/tools/testing/selftests/bpf/Makefile > index 438d4f93875b..133ebc68cbe4 100644 > --- a/tools/testing/selftests/bpf/Makefile > +++ b/tools/testing/selftests/bpf/Makefile > @@ -19,7 +19,7 @@ all: $(TEST_CUSTOM_PROGS) > $(TEST_CUSTOM_PROGS): urandom_read > > urandom_read: urandom_read.c > - $(CC) -o $(TEST_CUSTOM_PROGS) -static $< > + $(CC) -o $(TEST_CUSTOM_PROGS) -static $< -Wl,--build-id > > # Order correspond to 'make run_tests' order > TEST_GEN_PROGS = test_verifier test_tag test_maps test_lru_map test_lpm_map > test_progs \ > -- > 2.9.5 >
