On 05/10/2018 05:18 PM, Gao Feng wrote: > At 2018-05-10 21:02:55, "Eric Dumazet" <eric.duma...@gmail.com> wrote: >> >> >> On 05/10/2018 01:28 AM, gfree.w...@vip.163.com wrote: >>> From: Gao Feng <gfree.w...@vip.163.com> >>> >>> The skb flow limit is implemented for each CPU independently. In the >>> current codes, the function skb_flow_limit gets the softnet_data by >>> this_cpu_ptr. But the target cpu of enqueue_to_backlog would be not >>> the current cpu when enable RPS. As the result, the skb_flow_limit checks >>> the stats of current CPU, while the skb is going to append the queue of >>> another CPU. It isn't the expected behavior. >>> >>> Now pass the softnet_data as a param to softnet_data to make consistent. >>> >> >> Please add a correct Fixes: tag > > Thanks Eric. > > I have one question about the "Fixes: tag". > Most of patches are bug fixes, but when need to add the "Fixes: tag", and > when not ? > > I'm not clear about it. Could you explain it please? >
For this particular patch, since you have not CC Willem (author of the patch), I found very useful that you did a search to find out. Once you found which commit added the problem, simply add the Fixes: tag and CC: the author. Doing so saves us (stable teams, reviewers, maintainers) a lot of time really. In my opinion, Fixes: tags should be mandatory when applicable. > Best Regards > Feng > >> >> By doing so, you will likely add a CC: tag to make sure the author of the >> code >> will receive your email and give feed back. >> >> Thanks ! >>
