On 08-05-2018 15:45, Jose Abreu wrote: > The RX Descriptor is already initialized in at setup phase so there is > no need to set the values again, we just need to set the owner. This > allow us to remove another if condition. > > Signed-off-by: Jose Abreu <joab...@synopsys.com> > Cc: David S. Miller <da...@davemloft.net> > Cc: Joao Pinto <jpi...@synopsys.com> > Cc: Vitor Soares <soa...@synopsys.com> > Cc: Giuseppe Cavallaro <peppe.cavall...@st.com> > Cc: Alexandre Torgue <alexandre.tor...@st.com> > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index c5769b4..80439be 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -3255,10 +3255,7 @@ static inline void stmmac_rx_refill(struct stmmac_priv > *priv, u32 queue) > } > dma_wmb(); > > - if (unlikely(priv->synopsys_id >= DWMAC_CORE_4_00)) > - stmmac_init_rx_desc(priv, p, priv->use_riwt, 0, 0);
This cant be removed. Please don't merge it. Thanks and Best Regards, Jose Miguel Abreu > - else > - stmmac_set_rx_owner(priv, p); > + stmmac_set_rx_owner(priv, p); > > dma_wmb(); >
