On Wed, 9 May 2018 20:34:27 -0700 David Ahern <dsah...@gmail.com> wrote:
> Simple example of fast-path forwarding. It has a serious flaw > in not verifying the egress device index supports XDP forwarding. > If the egress device does not packets are dropped. > > Take this only as a simple example of fast-path forwarding. > > Signed-off-by: David Ahern <dsah...@gmail.com> > Acked-by: David S. Miller <da...@davemloft.net> Acked-by: Jesper Dangaard Brouer <bro...@redhat.com> I agree that sample program have this flaw, but it should not stop this patchset. We need to find a more reliable way of detecting/verifying that an egress device supports XDP forwarding, from within the BPF prog. As this sample program hints, we could do a lookup in the devmap, to get this info(?) -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer
