On Mon, 7 May 2018 13:14:33 +0200 GhantaKrishnamurthy MohanKrishna <mohan.krishna.ghanta.krishnamur...@ericsson.com> wrote:
> + struct opt *opts) > +{ > + struct opt *opt; > + > + if (!(opt = get_opt(opts, "media"))) { You don't need to have assignment in conditional context in this case. Please split the assignment and the if.