Re: [PATCH 1/1] NetLabel: add audit support for configuration changes

[James Morris]

> +struct audit_buffer *netlbl_audit_start_common(int type, u32 secid)

> +     if (current->mm) {
> +             down_read(&current->mm->mmap_sem);
> +             vma = current->mm->mmap;
> +             while (vma) {
> +                     if ((vma->vm_flags & VM_EXECUTABLE) &&
> +                         vma->vm_file) {
> +                             audit_log_d_path(audit_buf,
> +                                              " exe=",
> +                                              vma->vm_file->f_dentry,
> +                                              vma->vm_file->f_vfsmnt);
> +                             break;
> +                     }
> +                     vma = vma->vm_next;
> +             }
> +             up_read(&current->mm->mmap_sem);


Suggestion for the future: I think it'd be wortwhile consolidating this 
with the code in audit_log_task_info().

In any case, the patch looks fine to me.

Acked-by: James Morris <[EMAIL PROTECTED]>



- James
-- 
James Morris
<[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html