From: Ben Woodard <[EMAIL PROTECTED]> Date: Wed, 27 Sep 2006 11:52:57 -0700
> Because these are general utility clusters we run many different > programs and so trying to fix this problem in the application is not > possible since there are literally hundreds if not thousands of them. Then why add a socket option setting as your patch does? :-) I also object to the socket option setting being allowed for any user because this can have awful effects if allowed by arbitrary users on arbitrary networks. > We're more than willing to consider other approaches to handling this > particular workload better. We've even considered that TCP isn't at all > the right protocol but this affects several protocols including NFS and > the benefits of running NFS over TCP are too great. > > The original patch was prepared by Brian Behlendorf. He asked me to > adapt it for current kernels keep it up to date and send upstream. > > This may also help people like Andrew Athan which reported a similar > problem a couple of days ago on the linux-net mailing list: > http://www.uwsg.iu.edu/hypermail/linux/net/0609.3/0005.html I suspect > that it is more common a case than is widely recognized. > > Signed-off-by: Ben Woodard <[EMAIL PROTECTED]> > Signed-off-by: Brian Behlendorf <[EMAIL PROTECTED]> Other issues: 1) 2 "u32" in the tcp_sock is a lot of space to devote to this new state. If it can fit in 2 "u16"'s or even less space, please use that. 2) the expression "(tp->foo ? : sysctl_foo)" is repeated many times in the patch, please encapsulate it into an inline function or similar I'm still torn on the fundamental issues of this patch. I think random backoff is a better generic solution to this kind of problem. If it works for ethernet, it might just work for TCP too :-) Thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
