From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 27 Sep 2006 13:34:59 -0700
> [TG3]: Add basic 5906 support. > > Add support for the new 5709 device. This is a new 10/100 Mbps chip. > The mailbox access and firmware interface are quite different from > all other tg3 chips. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Looks fine, applied. Quick question: > @@ -491,6 +513,9 @@ static inline void tg3_cond_int(struct t > if (!(tp->tg3_flags & TG3_FLAG_TAGGED_STATUS) && > (tp->hw_status->status & SD_STATUS_UPDATED)) > tw32(GRC_LOCAL_CTRL, tp->grc_local_ctrl | GRC_LCLCTRL_SETINT); > + else > + tw32(HOSTCC_MODE, tp->coalesce_mode | > + (HOSTCC_MODE_ENABLE | HOSTCC_MODE_NOW)); > } > > static void tg3_enable_ints(struct tg3 *tp) Why are we forcing a coalescing event here now? This seems to apply in quite a large number of cases. It will trigger if either: 1) using tagged status 2) SD_STATUS_UPDATED is not indicated in the status block In particular, how is this a 5906 specific support change when there are no 5906 or other chipset conditionals guarding the logic here? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
