From: Li RongQing <roy.qing...@gmail.com> Date: Wed, 25 Apr 2018 16:35:02 +0800
> On 4/20/18, David Miller <da...@davemloft.net> wrote: >> From: Li RongQing <lirongq...@baidu.com> >> Date: Thu, 19 Apr 2018 12:59:21 +0800 >> >>> The input of css_cls_state() is impossible to NULL except >>> cgrp_css_online, so simplify it >>> >>> Signed-off-by: Li RongQing <lirongq...@baidu.com> >> >> I don't view this as an improvement. Just let the helper always check >> NULL and that way there are less situations to audit. >> > css_cls_state maybe return NULL, but nearly no places check the return > value with NULL, this seems unreadable. I saw this email of your's the first few times, you don't need to post it again. I still disagree with your analysis, and I do not see your change as an overall improvement. Thank you.
