From: Colin Ian King <colin.k...@canonical.com>

There are two identical nested if statements, the second is redundant
and can be removed. Also clean up white space formatting.

Cleans up cppcheck warning:
drivers/net/ethernet/amd/amd8111e.c:1080: (warning) Identical inner 'if'
condition is always true.

Signed-off-by: Colin Ian King <colin.k...@canonical.com>
---
 drivers/net/ethernet/amd/amd8111e.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/drivers/net/ethernet/amd/amd8111e.c 
b/drivers/net/ethernet/amd/amd8111e.c
index c99e3e845ac0..a90080f12e67 100644
--- a/drivers/net/ethernet/amd/amd8111e.c
+++ b/drivers/net/ethernet/amd/amd8111e.c
@@ -1074,16 +1074,12 @@ static int amd8111e_calc_coalesce(struct net_device 
*dev)
                                amd8111e_set_coalesce(dev,TX_INTR_COAL);
                                coal_conf->tx_coal_type = MEDIUM_COALESCE;
                        }
-
-               }
-               else if(tx_pkt_size >= 1024){
-                       if (tx_pkt_size >= 1024){
-                               if(coal_conf->tx_coal_type !=  HIGH_COALESCE){
-                                       coal_conf->tx_timeout = 4;
-                                       coal_conf->tx_event_count = 8;
-                                       amd8111e_set_coalesce(dev,TX_INTR_COAL);
-                                       coal_conf->tx_coal_type = HIGH_COALESCE;
-                               }
+               } else if (tx_pkt_size >= 1024) {
+                       if (coal_conf->tx_coal_type != HIGH_COALESCE) {
+                               coal_conf->tx_timeout = 4;
+                               coal_conf->tx_event_count = 8;
+                               amd8111e_set_coalesce(dev, TX_INTR_COAL);
+                               coal_conf->tx_coal_type = HIGH_COALESCE;
                        }
                }
        }
-- 
2.17.0

Reply via email to