On Wed, 2006-09-27 at 16:47 -0400, Jeff Garzik wrote:
> Michael Chan wrote:
> > + /* Chip might not be fitted with firmware. Some Sun onboard
> > + * parts are configured like that. So don't signal the timeout
> > + * of the above loop as an error, but do report the lack of
> > + * running firmware once.
> > + */
> > + if (i >= 100000 &&
> > + !(tp->tg3_flags2 & TG3_FLG2_NO_FWARE_REPORTED)) {
> > + tp->tg3_flags2 |= TG3_FLG2_NO_FWARE_REPORTED;
> > +
> > + printk(KERN_INFO PFX "%s: No firmware running.\n",
> > + tp->dev->name);
> > + }
> > +
> > + return 0;
>
> You need to actually return failure, for the failure case.
>
> Currently, this function is written to return an error code, but always
> returns zero.
>
It's actually not a failure. It was decided that we'll just print a
message once and continue. Some SUN onboard chips do not have firmware.
In the next patch (6/9) where we support a new chip with a new firmware
polling method, it can return -ENODEV.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
