Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

[Stephen Hemminger]

On Tue, 24 Apr 2018 13:44:06 +0200
Toke Høiland-Jørgensen <t...@toke.dk> wrote:

> +static const u8 precedence[] = {0, 0, 0, 0, 0, 0, 0, 0,
> +                             1, 1, 1, 1, 1, 1, 1, 1,
> +                             2, 2, 2, 2, 2, 2, 2, 2,
> +                             3, 3, 3, 3, 3, 3, 3, 3,
> +                             4, 4, 4, 4, 4, 4, 4, 4,
> +                             5, 5, 5, 5, 5, 5, 5, 5,
> +                             6, 6, 6, 6, 6, 6, 6, 6,
> +                             7, 7, 7, 7, 7, 7, 7, 7,
> +                             };

Minor nit.  The kernel style for initializing array should be used
here.

static const u8 precedence[] = {
        0, 0, 0, 0, 0, 0, 0, 0,
        1, 1, 1, 1, 1, 1, 1, 1,
...
};