Hi, May I know the final decision of this patch? Thanks.
Best regards, AceLan Kao. 2018-04-10 10:40 GMT+08:00 AceLan Kao <acelan....@canonical.com>: > The problem is I don't have a machine with that wakeup issue, and I > need WoL feature. > Instead of spreading "alx with WoL" dkms package everywhere, I would > like to see it's supported in the driver and is disabled by default. > > Moreover, the wakeup issue may come from old Atheros chips, or result > from buggy BIOS. > With the WoL has been removed from the driver, no one will report > issue about that, and we don't have any chance to find a fix for it. > > Adding this feature back is not covering a paper on the issue, it > makes people have a chance to examine this feature. > > 2018-04-09 22:50 GMT+08:00 David Miller <da...@davemloft.net>: >> From: Andrew Lunn <and...@lunn.ch> >> Date: Mon, 9 Apr 2018 14:39:10 +0200 >> >>> On Mon, Apr 09, 2018 at 07:35:14PM +0800, AceLan Kao wrote: >>>> The WoL feature was reported broken and will lead to >>>> the system resume immediately after suspending. >>>> This symptom is not happening on every system, so adding >>>> disable_wol option and disable WoL by default to prevent the issue from >>>> happening again. >>> >>>> const char alx_drv_name[] = "alx"; >>>> >>>> +/* disable WoL by default */ >>>> +bool disable_wol = 1; >>>> +module_param(disable_wol, bool, 0); >>>> +MODULE_PARM_DESC(disable_wol, "Disable Wake on Lan feature"); >>>> + >>> >>> Hi AceLan >>> >>> This seems like you are papering over the cracks. And module >>> parameters are not liked. >>> >>> Please try to find the real problem. >> >> Agreed.
