On Wed, Apr 11, 2018 at 11:43 AM, Jakub Kicinski <kubak...@wp.pl> wrote:
> On Wed, 11 Apr 2018 11:50:14 -0400, Michael Chan wrote:
>> @@ -764,6 +788,41 @@ static bool bnxt_tc_can_offload(struct bnxt *bp, struct
>> bnxt_tc_flow *flow)
>> return false;
>> }
>>
>> + /* Currently source/dest MAC cannot be partial wildcard */
>> + if (bits_set(&flow->l2_key.smac, sizeof(flow->l2_key.smac)) &&
>> + !is_exactmatch(flow->l2_mask.smac, sizeof(flow->l2_mask.smac))) {
>> + netdev_info(bp->dev, "Wildcard match unsupported for Source
>> MAC\n");
>
> This wouldn't be something to do in net, but how do you feel about
> using extack for messages like this?
>
Sounds reasonable to me. Just need to pass in the extack pointer to
this function to set the netlink error message.
