On Tue, 2018-04-10 at 15:53 +0300, Igor Russkikh wrote:
> On 10.04.2018 15:42, Yanko Kaneti wrote:
> > Hello,
> >
> > Since 90869ddfefeb net: aquantia: Implement pci shutdown callback
> > I get the below oops on reboot. Without the callback everything works
> > as expected.
> >
>
> Thanks, we also recently found out that.
>
> Could you please try the below patch?
Works for me, as in, no crashes on reboot.
Thanks
-Yanko
>
>
> diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> index c96a921..32f6d2e 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> @@ -951,9 +951,11 @@ void aq_nic_shutdown(struct aq_nic_s *self)
>
> netif_device_detach(self->ndev);
>
> - err = aq_nic_stop(self);
> - if (err < 0)
> - goto err_exit;
> + if (netif_running(self->ndev)) {
> + err = aq_nic_stop(self);
> + if (err < 0)
> + goto err_exit;
> + }
> aq_nic_deinit(self);
>
> err_exit:
