From: Florian Fainelli <f.faine...@gmail.com> Date: Wed, 28 Mar 2018 15:15:35 -0700
> Following Tal's review of the adaptive RX/TX coalescing feature added to the > SYSTEMPORT and GENET driver a number of things showed up: > > - adaptive TX coalescing is not actually a good idea with the current way > the estimator will program the ring, this results in a higher CPU load, NAPI > on TX already does a reasonably good job at maintaining the interrupt count > low > > - both SYSTEMPORT and GENET would suffer from the same issues while > configuring > coalescing parameters where the values would just not be applied correctly > based on user settings, so we fix that too > > Tal, thanks again for your feedback, I would appreciate if you could review > that > the new behavior appears to be implemented correctly. ... > Changes in v2: > > - added Tal's reviewed-by to the first patch > - split DIM initialization from coalescing parameters initialization > - avoid duplicating the same code in bcmgenet_set_coalesce() when configuring > RX rings > - fixed the condition where default DIM parameters would be applied when > adaptive RX coalescing would be enabled, do this only if it was disabled > before Series applied, thanks Florian.
