On Tue, Mar 27, 2018 at 3:26 PM, Dave Watson <davejwat...@fb.com> wrote:
> Thanks for doing the merge, it looks good to me. One issue below,
> otherwise all my SW tests still pass.
>
> On 03/27/18 02:51 PM, Saeed Mahameed wrote:
>> - if (ctx->conf == TLS_SW_TX ||
>> - ctx->conf == TLS_SW_RX ||
>> - ctx->conf == TLS_SW_RXTX) {
>> - tls_sw_free_resources(sk);
>> + if (ctx->rx_conf == TLS_SW) {
>> + kfree(ctx->rx.rec_seq);
>> + kfree(ctx->rx.iv);
>> + tls_sw_free_resources_rx(sk);
>> }
>>
>> + if (ctx->tx_conf != TLS_HW)
>> + kfree(ctx);
>
> Looks like this needs to be hidden behind CONFIG_TLS_DEVICE, otherwise
> it doesn't compile if false because TLS_HW is not defined
>
Correct, Will fix.
Thanks Dave !
