Hi all, Following Tal's review of the adaptive RX/TX coalescing feature added to the SYSTEMPORT and GENET driver a number of things showed up:
- adaptive TX coalescing is not actually a good idea with the current way the estimator will program the ring, this results in a higher CPU load, NAPI on TX already does a reasonably good job at maintaining the interrupt count low - both SYSTEMPORT and GENET would suffer from the same issues while configuring coalescing parameters where the values would just not be applied correctly based on user settings, so we fix that too Tal, thanks again for your feedback, I would appreciate if you could review that the new behavior appears to be implemented correctly. Thanks! Florian Fainelli (3): net: systemport: Remove adaptive TX coalescing net: systemport: Fix coalescing settings handling net: bcmgenet: Fix coalescing settings handling drivers/net/ethernet/broadcom/bcmsysport.c | 118 ++++++++++--------------- drivers/net/ethernet/broadcom/bcmsysport.h | 5 +- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 78 +++++++++++----- drivers/net/ethernet/broadcom/genet/bcmgenet.h | 4 +- 4 files changed, 106 insertions(+), 99 deletions(-) -- 2.14.1
