On 03/26/18 01:44 PM, Tom Herbert wrote: > On Mon, Mar 26, 2018 at 12:31 PM, Dave Watson <davejwat...@fb.com> wrote: > > strp_parser_err is called with a negative code everywhere, which then > > calls abort_parser with a negative code. strp_msg_timeout calls > > abort_parser directly with a positive code. Negate ETIMEDOUT > > to match signed-ness of other calls. > > > > The default abort_parser callback, strp_abort_strp, sets > > sk->sk_err to err. Also negate the error here so sk_err always > > holds a positive value, as the rest of the net code expects. Currently > > a negative sk_err can result in endless loops, or user code that > > thinks it actually sent/received err bytes. > > > > Found while testing net/tls_sw recv path. > > > Nice catch! > > It might be nice to have a comment at strp_parser_err and abort_parser > description in Documentation/networking/strparser.txt should also be > updated that err is a negative error value.
Sure I can update the docs also.
