On 03/26/2018 09:58 AM, David Miller wrote: > From: Mike Looijmans <mike.looijm...@topic.nl> > Date: Mon, 26 Mar 2018 08:41:29 +0200 > >> It's common practice to store MAC addresses for network interfaces into >> nvmem devices. However the code to actually do this in the kernel lacks, >> so this patch adds of_get_nvmem_mac_address() for drivers to obtain the >> address from an nvmem cell provider. >> >> This is particulary useful on devices where the ethernet interface cannot >> be configured by the bootloader, for example because it's in an FPGA. >> >> Tested by adapting the cadence macb driver to call this instead of >> of_get_mac_address(). >> >> Signed-off-by: Mike Looijmans <mike.looijm...@topic.nl> >> --- >> v2: Use of_nvmem_cell_get to avoid needing the assiciated device >> Use void* instead of char* >> Add devicetree binding doc > > Like Andrew, I think you should add a new interface for getting the MAC > address from nvmem. > > And drivers can call both of them if they want OF device tree and > NVMEM probing for MAC addresses. > > Later you can add a consolidated interface, if necessary, which does > both and also take a reference to the MAC address buffer of the driver > in order to deal with the resource allocation issues.
Agreed, also, how does this fit with Alban's patch series here: https://lkml.org/lkml/2018/3/24/312 do you depend on those changes at all? -- Florian
