On 3/18/18 2:40 AM, Kevin Darbyshire-Bryant wrote: > > >> On 16 Mar 2018, at 20:34, Stephen Hemminger <step...@networkplumber.org> >> wrote: >>> >>> print_uint64(PRINT_ANY, "refcnt", "refcnt %" PRIu64 " ", t->tcm_info) >>> >>> Signed-off-by: Kevin Darbyshire-Bryant <l...@darbyshire-bryant.me.uk> >> >> I am fine with this. But since there is no code using it yet, it should >> go net-next branch. >> >> Reviewed-by: Stephen Hemminger <step...@networkplumber.org> > > Existing code is tripping up over the hidden uint - > uint64_t promotion in > print_uint in iproute2 v4.15, that’s how I fell over the issue. Should I > split the patch? One fixing the uint->uint64_t and the other offering the > explicit type length options. > > Obviously I now realise that the email header should have iproute2 in it. > Learning, slowly :-) >
Kevin: I guess you need to split the patch. Extract the bug fix piece and send for iproute2; enhancements go to iproute2-next.
