From: Jeff Kirsher <[email protected]> Date: Wed, 21 Mar 2018 14:48:08 -0700
> On Wed, 2018-03-21 at 14:56 -0400, Sinan Kaya wrote: >> Remove ixgbevf_write_tail() in favor of moving writel() close to >> wmb(). >> >> Signed-off-by: Sinan Kaya <[email protected]> >> Reviewed-by: Alexander Duyck <[email protected]> >> --- >> drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 5 ----- >> drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++-- >> 2 files changed, 2 insertions(+), 7 deletions(-) > > This patch fails to compile because there is a call to > ixgbevf_write_tail() which you missed cleaning up. For a change with delicate side effects, it doesn't create much confidence if the code does not even compile. Sinan, please put more care into the changes you are making. Thank you.
