On 03/20/2018 10:11 AM, David Lebrun wrote: > On 20/03/18 15:07, Eric Dumazet wrote: >> This is not the proper fix. >> >> Control path holds RTNL and can sleeep if needed. >> >> RCU should be avoided in lwtunnel_build_state() >> > > +Roopa > > In lwtunnel_build_state(), the RCU protects the lwtunnel_encap_ops "ops" > which is rcu-dereferenced. Moreover, the lwtunnel_state_alloc() function, > which is used in all build_state functions, also uses GFP_ATOMIC, so this > seemed a proper fix, or at least proper mitigation. > > Do you suggest that the lwtunnel_encap_ops can be protected in a different > way, not requiring RCU ?
Yes, GFP_ATOMIC might be an 'easy fix' for net tree, but for the future, GFP_KERNEL allocations make more sense in control path. Many scripts do not handle errors correctly and simply abort. In case of failure, they might retry (busy poll) in the best scenario, consuming cycles that might be needed to exit from pressure. GFP_KERNEL allocations provide proper scheduling, they really should be the norm for control path.
