From: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp> Date: Tue, 13 Mar 2018 14:51:26 +0900
> As Brandon Carpenter reported[1], sending non-vlan-offloaded packets from > bridge devices ends up with corrupted packets. He narrowed down this problem > and found that the root cause is in skb_reorder_vlan_header(). > > While I was working on fixing this problem, I found that the function does > not work properly for double tagged packets with reorder_hdr off as well. > > Patch 1 fixes these 2 problems in skb_reorder_vlan_header(). > > And it turned out that fixing skb_reorder_vlan_header() is not sufficient > to receive double tagged packets with reorder_hdr off while I was testing the > fix. Vlan tags got out of order when vlan devices with reorder_hdr disabled > were stacked. Patch 2 fixes this problem. > > [1] https://www.spinics.net/lists/linux-ethernet-bridging/msg07039.html Series applied and queued up for -stable, thanks. I was thinking of pushing back on the addition of the ETH_TLEN UAPI visible macro, because I don't see any other system providing that define. But in the end I decided that it's harmless and really that header file is the correct location for such a definition. Thank you.
