Re: [PATCH] lan78xx: Connect phy early

[Andrew Lunn]

> @@ -2082,8 +2082,6 @@ static int lan78xx_phy_init(struct lan78xx_net *dev)
>  
>       dev->fc_autoneg = phydev->autoneg;
>  
> -     phy_start(phydev);
> -
>       netif_dbg(dev, ifup, dev->net, "phy initialised successfully");
>  
>       return 0;
> @@ -2512,9 +2510,7 @@ static int lan78xx_open(struct net_device *net)
>       if (ret < 0)
>               goto done;
>  
> -     ret = lan78xx_phy_init(dev);
> -     if (ret < 0)
> -             goto done;
> +     phy_start(net->phydev);

Should the debug message be moved as well?

       Andrew