On Mon, Mar 12, 2018 at 03:30:53PM -0700, Florian Fainelli wrote:
> On 03/12/2018 02:57 PM, Andrew Lunn wrote:
> >> + /* attempt to find a phy-handle */
> >> + if (!(bp->phy_node = of_parse_phandle(np, "phy-handle",
> >> 0))) {
> >> +
> >> + /* fallback to standard phy registration if no
> >> phy were
> >> + * found during dt phy registration
> >> + */
> >> + if (!phy_find_first(bp->mii_bus)) {
> >> + for (i = 0; i < PHY_MAX_ADDR; i++) {
> >> + struct phy_device *phydev;
> >> +
> >> + phydev =
> >> mdiobus_scan(bp->mii_bus, i);
> >> + if (IS_ERR(phydev) &&
> >> + PTR_ERR(phydev) != -ENODEV)
> >> {
> >> + ret = PTR_ERR(phydev);
> >> + break;
> >> + }
> >
> > Hi Brad
>
> I would be a bit relaxed on these warnings because the existing function
> indentation really makes it easy to be over 80 columns. Unless you have
> a preliminary patch which, as I was suggesting earlier, re-arranges the
> branches such that if (!np) is the first thing you test, I don't see how
> this can look any better...
I'll try to work this a bit more, thanks for the feedback and the
patience.
--
Brad
