Auke Kok <[EMAIL PROTECTED]> :
[...]
> >tg3/bnx2/sky2/b44/8139cp
>
> Can I add e1000/ixgb to that? ;)
Assume I have not noticed the smiley...
- $ grep int32 drivers/net/e1000/*
- $ grep ' if(' drivers/net/e1000/*
- tabs and spaces damage
- forward declarations (are not a substitute for documentation)
- static some_return_type
e1000_shnortz(...
I still use dumb grep
- wild return -EIO; in the middle of e1000_probe
- useless cast in e1000_probe::INIT_WORK() due to wrong prototype
of e1000_reset_task().
It looks nicer than last time I poke my nose into it but I am not
completely sure that I would recommend it to a newcomer as the
climax of best practices or simplicity. Btw I do not remember if
it handles multi-page skb like everybody else either.
--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
