From: Gal Pressman <g...@mellanox.com> Date: Sun, 4 Mar 2018 14:12:04 +0200
> LRO and RX-FCS offloads cannot be enabled at the same time since it is > not clear what should happen to the FCS of each coalesced packet. > The FCS is not really part of the TCP payload, hence cannot be merged > into one big packet. On the other hand, providing one big LRO packet > with one FCS contradicts the RX-FCS feature goal. > > Use the fix features mechanism in order to prevent intersection of the > features and drop LRO in case RX-FCS is requested. > > Enabling RX-FCS while LRO is enabled will result in: > $ ethtool -K ens6 rx-fcs on > Actual changes: > large-receive-offload: off [requested on] > rx-fcs: on > > Signed-off-by: Gal Pressman <g...@mellanox.com> > Reviewed-by: Tariq Toukan <tar...@mellanox.com> Agreed, having these two options enabled at the same time doesn't make any sense. Applied. Probably need to add the same restriction for HW GRO.
