From: Felix Manlunas <felix.manlu...@cavium.com>
Date: Fri, 2 Mar 2018 18:59:10 -0800

> Added support to the ndo_get_phys_port_id() callback to provide
> port specific unique id to the netdev layer.
> 
> Port id needs to be unique across different liquidio devices in the system.
> So used MAC address for port_id.

This doesn't look right at all.

The physical port ID is used in order to distinguish several netdev
devices present on the same PHYSICAL PORT.

So you should be using a number that is unique within a physical
port.

Using the MAC address for this doesn't make any sense at all.

Reply via email to