Hello Andrew,

I've noticed that my device model is mv88e6390x and not mv88e6352 as I wrote 
before.
What is the compatibility value for it?

Regards,
Michael

-----Original Message-----
From: Andrew Lunn [mailto:[email protected]] 
Sent: Sunday, March 04, 2018 5:31 PM
To: Alayev Michael
Cc: '[email protected]'; Dror Alon; Efter Yoram
Subject: Re: dsa with 2 rgmii channels (1st is 2 switches & 2nd is phy)

Hi Michael

>                 mdio {
>                                 compatible = "cdns,macb-mdio";
> /*                           reg = <0xe000b000 0x1000>; */
> /*                           clocks = <&clkc 30>, <&clkc 30>, <&clkc 13>; */
> /*                           clock-names = "pclk", "hclk", "tx_clk"; */
>                                 #address-cells = <1>;
>                                 #size-cells = <0>;
>                                 status = "okay";
>                                 switch0: switch@0 {
>                                                 compatible = 
> "marvell,mv88e6352";

Please use marvell,mv88e6085. That is what the 6352 is compatible with.

It would also be good to sort out your mixup between tabs and spaces.

>                 mdio {
>                                 compatible = "cdns,macb-mdio";
> /*                           reg = <0xe000c000 0x1000>; */
> /*                           clocks = <&clkc 31>, <&clkc 31>, <&clkc 14>; */
> /*                           clock-names = "pclk", "hclk", "tx_clk"; */
>                                 #address-cells = <1>;
>                                 #size-cells = <0>;
>                                 status = "okay";
>                                 ethernet_phy: ethernet-phy@0 {
>                                                 compatible = 
> "marvell,mv88e1510";
>                                                 device_type = "ethernet-phy";
>                                                 reg = <0>;
>                                 };

PHYs don't have compatible strings. It is not needed, you can read the vendor 
and model from its registers.

       Andrew

Default Profile
***********************************************************************************************

Please consider the environment before printing this email !
The information contained in this communication is proprietary to Israel 
Aerospace Industries Ltd. and/or third parties, may contain confidential or 
privileged information, and is intended only for the use of the intended 
addressee thereof.
If you are not the intended addressee, please be aware that any use, 
disclosure, distribution and/or copying of this communication is strictly 
prohibited. If you receive this communication in error, please notify the 
sender immediately and delete it from your computer. 
Thank you.

Visit us at:   www.iai.co.il

Reply via email to