Error code is already returned earlier if filter exists
at specified location. So, remove dead code trying to
free existing filter.

Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
Signed-off-by: Ganesh Goudar <ganes...@chelsio.com>
Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com>
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c 
b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
index 3177b0c..db92f18 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
@@ -1335,12 +1335,6 @@ int __cxgb4_set_filter(struct net_device *dev, int 
filter_id,
                return ret;
        }
 
-       /* Clear out any old resources being used by the filter before
-        * we start constructing the new filter.
-        */
-       if (f->valid)
-               clear_filter(adapter, f);
-
        if (is_t6(adapter->params.chip) && fs->type &&
            ipv6_addr_type((const struct in6_addr *)fs->val.lip) !=
            IPV6_ADDR_ANY) {
-- 
2.1.0

Reply via email to