Re: [PATCH net-next 02/14] selftests: forwarding: Add a test for FDB learning

[Petr Machata]

Ido Schimmel <ido...@mellanox.com> writes:

> +learning_test()
> +{
> +     local mac=de:ad:be:ef:13:37
> +     local ageing_time
> +     local br_port1=$2       # Connected to `host1_if`.
> +     local host1_if=$3
> +     local host2_if=$4
> +     local bridge=$1

I don't think applying RXT in Bash is appropriate. The ordering of the
local variables should instead follow the order of function arguments,
because that information isn't communicated by the function prototype
itself, unlike C.

Thanks,
Petr