On Sun, Feb 25, 2018 at 02:00:43PM +0100, Heiner Kallweit wrote: > Am 03.02.2018 um 21:17 schrieb Andrew Lunn: > > On Sat, Feb 03, 2018 at 05:41:54PM +0100, Heiner Kallweit wrote: > >> This commit forces callers of phy_resume() and phy_suspend() to hold > >> mutex phydev->lock. This was done for calls to phy_resume() and > >> phy_suspend() in phylib, however there are more callers in network > >> drivers. I'd assume that these other calls issue a warning now > >> because of the lock not being held. > >> So is there something I miss or would this have to be fixed? > > > > Hi Heiner > > > > This is a good point. > > > > Yes, it looks like some fixes are needed. But what exactly? > > > The issue with phy_suspend/phy_resume and the changed locking > behavior is still open AFAICS. There was a proposed fix > https://www.mail-archive.com/netdev@vger.kernel.org/msg215455.html > and then the discussion stopped. > I think we need the fix before 4.16 leaves the rc phase.
Hi Heiner I have a patch i will post later today. Andrew
