David Ahern wrote: > On 2/22/18 6:02 AM, Serhey Popovych wrote: >> @@ -650,6 +658,9 @@ int iplink_parse(int argc, char **argv, struct >> iplink_req *req, >> bool drv = strcmp(*argv, "xdpdrv") == 0; >> bool offload = strcmp(*argv, "xdpoffload") == 0; >> >> + if (offload) >> + has_dev(*dev, dev_index); >> + > > I think this is actually the wrong direction. seems to me argv should be > passed to xdp_parse rather than the generic, drv, offload bool's. That > function can then the check on which option it is and has the knowledge > about whether a device is needed or not.
Okay, I probably will prepare another change instead that accounts your suggestions. Will add it to v4 later. > > >> NEXT_ARG(); >> if (xdp_parse(&argc, &argv, req, dev_index, >> generic, drv, offload))
signature.asc
Description: OpenPGP digital signature
