On 2/19/18 3:19 PM, Serhey Popovych wrote:
> I get following checkpatch.pl warnings:
> 
> WARNING: Missing a blank line after declarations
> #73: FILE: ip/iptuntap.c:497:
> +               __u8 mq = rta_getattr_u8(tb[IFLA_TUN_MULTI_QUEUE]);
> +               if (!mq)
> 
> WARNING: Missing a blank line after declarations
> #80: FILE: ip/iptuntap.c:504:
> +               __u32 numq = rta_getattr_u32(tb[IFLA_TUN_NUM_QUEUES]);
> +               fprintf(f, "numqueues %u ", numq);
> 
> WARNING: Missing a blank line after declarations
> #85: FILE: ip/iptuntap.c:509:
> +               __u32 numq =
> rta_getattr_u32(tb[IFLA_TUN_NUM_DISABLED_QUEUES]);
> +               fprintf(f, "numdisabled %u ", numq);
> 
> maybe they should be fixed before accepting?

yes. Please fix; headers have been updated to 4.16.0-rc2+, f5c0c6f4299f,
so you can drop those from v2

Reply via email to