On Fri, Feb 16, 2018 at 6:53 PM, Colin Ian King <colin.k...@canonical.com> wrote: > On 16/02/18 16:51, Andy Shevchenko wrote: >> On Thu, Feb 15, 2018 at 9:42 PM, Colin King <colin.k...@canonical.com> wrote:
>>> + filter->f.mask.tcp_spec.dst_ip[i] |= >>> >>> cpu_to_be32(0xffffffff); >> >> Can it be one line then? > > I re-adjusted the text because checkpatch was complaining. >> >>> + filter->f.mask.tcp_spec.src_ip[i] |= >>> >>> cpu_to_be32(0xffffffff); For the rest OK, but for the above two how much over 80 it went if would be one line? If it 2-3 characters, consider to make it one line. It would increase readability. -- With Best Regards, Andy Shevchenko
