On Thu, Feb 15, 2018 at 2:11 AM, David Miller <da...@davemloft.net> wrote: > From: Matteo Croce <mcr...@redhat.com> > Date: Wed, 14 Feb 2018 19:13:42 +0100 > >> The IPVlan module currently depends on IPv6 and Netfilter. >> Refactor the code to allow building IPVlan module regardless of the value of >> CONFIG_IPV6 and CONFIG_NETFILTER. >> Also change the dependency to CONFIG_NET_L3_MASTER_DEV into a select, >> as compiling L3 Master device alone has no sense. > > As stated, the L3 master and netfilter are hard depenencies when using > ipvlan in some modes. > > You can't just ifdef the driver like this, it changes fundamental > pieces of functionality. > > I would say leave things as they are right now.
Hi David, yes, I noticed that L3 master and netfilter are really needed in l3s mode, so let's drop patch 2/3. What about the other two, removing IPv6 and change the Kconfig? Other devices like VXLan, Geneve and VRF uses the same architecture to allow conditional compilation of the IPv6 module, I think that IPVlan should do the same. Regards, -- Matteo Croce per aspera ad upstream
