On 02/13/2018 05:19 PM, Daniel Borkmann wrote:
> Hi Eric,
>
> On 02/14/2018 12:43 AM, Eric Dumazet wrote:
>> On Tue, 2018-02-13 at 15:33 -0800, Eric Dumazet wrote:
>>> From: Eric Dumazet <eduma...@google.com>
>>>
>>> In case user program provides silly parameters, we want
>>> a map_alloc() handler to return an error, not a NULL pointer,
>>> otherwise we crash later in find_and_alloc_map()
>>>
>>> Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support")
>>> Signed-off-by: Eric Dumazet <eduma...@google.com>
>>> Reported-by: syzbot <syzkal...@googlegroups.com>
>>> ---
Thanks Eric, also great to see syzkaller working on the sockmap
types.
Acked-by: John Fastabend <john.fastab...@gmail.com>
>>
>> This would apply to net or bpf trees, not -next ones, sorry for the
>> confusion in the [PATCH bpf-next] prefix.
>
> No problem, thanks for the fix!
>
>> Bug was added in 4.14
>
> Fixes tag is actually slightly different, it would be:
>
> Fixes: 1aa12bdf1bfb ("bpf: sockmap, add sock close() hook to remove socks")
>
Yep.
> I can change it if you want, no need to resend.> Thanks,
> Daniel
>
