On Tue, 05 Sep 2006 13:42:38 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
> On Mon, 2006-09-04 at 20:34 -0700, Stephen Hemminger wrote: > > Unneeded byte swap was occurring. > > > > --- linux-2.6.orig/drivers/net/sky2.c > > +++ linux-2.6/drivers/net/sky2.c > > @@ -2001,7 +2001,7 @@ static int sky2_status_intr(struct sky2_ > > case OP_RXCHKS: > > skb = sky2->rx_ring[sky2->rx_next].skb; > > skb->ip_summed = CHECKSUM_HW; > > - skb->csum = le16_to_cpu(status); > > + skb->csum = status; > > break; > > > > case OP_TXINDEXLE: > > I've removed it in my paches (have you seen the other patches I sent for > this driver ?), though I'm pre-swapping status and lenght now before the > switch/case so there might still be an issue there. I'll have a look. The other tack would be to leave the "reverse in hw" flag on and take out all the existing swap calls but then you have to add an ifdef to re-order all the structures for tx_le, rx_le, status_le. That is what the vendor (GPL) version of sk98lin does. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
