On Thu, Jan 25, 2018 at 10:34 AM, William Tu <u9012...@gmail.com> wrote:
> Thanks for the review.
>
> On Thu, Jan 25, 2018 at 9:32 AM, Pravin Shelar <pshe...@ovn.org> wrote:
>> On Wed, Jan 24, 2018 at 11:06 AM, William Tu <u9012...@gmail.com> wrote:
>>> The patch adds support for openvswitch to configure erspan
>>> v1 and v2. The OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS attr is added
>>> to uapi as a binary blob to support all ERSPAN v1 and v2's
>>> fields. Note that Previous commit "openvswitch: Add erspan tunnel
>>> support." was reverted since it does not design properly.
>>>
>>> Signed-off-by: William Tu <u9012...@gmail.com>
>>> ---
>>> include/uapi/linux/openvswitch.h | 2 +-
>>> net/openvswitch/flow_netlink.c | 90
>>> +++++++++++++++++++++++++++++++++++++++-
>>> 2 files changed, 90 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/include/uapi/linux/openvswitch.h
>>> b/include/uapi/linux/openvswitch.h
>>> index dcfab5e3b55c..158c2e45c0a5 100644
>>> --- a/include/uapi/linux/openvswitch.h
>>> +++ b/include/uapi/linux/openvswitch.h
>>> @@ -273,7 +273,6 @@ enum {
>>>
>>> #define OVS_VXLAN_EXT_MAX (__OVS_VXLAN_EXT_MAX - 1)
>>>
>>> -
>>> /* OVS_VPORT_ATTR_OPTIONS attributes for tunnels.
>>> */
>>> enum {
>>> @@ -363,6 +362,7 @@ enum ovs_tunnel_key_attr {
>>> OVS_TUNNEL_KEY_ATTR_IPV6_SRC, /* struct in6_addr src IPv6
>>> address. */
>>> OVS_TUNNEL_KEY_ATTR_IPV6_DST, /* struct in6_addr dst IPv6
>>> address. */
>>> OVS_TUNNEL_KEY_ATTR_PAD,
>>> + OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS, /* struct erspan_metadata */
>>> __OVS_TUNNEL_KEY_ATTR_MAX
>>> };
>>>
>> Since this is uapi, we need to define the struct erspan_metadata in a
>> UAPI header file.
>
> Should I define "struct erspan_metadata" in include/uapi/linux/openvswitch.h?
>
> Or I'm planning to create a new file in uapi "include/uapi/linux/erspan.h",
> define "struct erspan_metadata" there, and remove its duplicate at
> include/net/erspan.h.
>
Better to define separate header for ERSPAN.
Thanks,
Pravin.
