On 1/25/18 8:24 AM, Jiri Pirko wrote: >>>> Now I remember. You wrote it independently and but needed iproute2 be a >>>> delivery vehicle. It uses none of the common infrastructure from >>>> iproute2. Could we make this more difficult .... >>> >>> Feel free to rewrite it to use lib/libnetlink.c. Should not be that >>> hard. Note that at the time I was pushing devlink userspace, tipc also >>> used libmnl as a part of iproute2, so devlink was not the first one. >>> That is why I decided not to rewrite. >>> >>> As of the rest of the "common infrastructure", what exactly do you >>> have in mind? >>> >> >> This is what I am getting at. Apparently, these resource patches for >> devlink require a patched libmnl to work properly. It is wrong for > > What do you mean, "work properly". If there is no patched libmnl, only > thing what happens is that the extack won't be processed and shown. > That is the same behaviour as if you compile iproute2 package without > libmnl - all works, used just don't see extack messages. > > I don't see any problem in that. Do you?
I have libmnl installed. I build iproute2. I don't get extended ack messages on devlink failures. That is a problem. That is building a command that is known not to work as it should given the build dependencies.
