Re: [PATCH bpf-next v6 04/11] bpf: Support passing args to sock_ops bpf function

[Daniel Borkmann]

On 01/24/2018 02:30 AM, Lawrence Brakmo wrote:
> On 1/23/18, 5:11 PM, "Daniel Borkmann" <dan...@iogearbox.net> wrote:
[...]
>     > +{
>     > +       return -EPERM;
>     > +}
>     > +
>     > +static inline int tcp_call_bpf_4arg(struct sock *sk, int op, u32 arg1, 
> u32 arg2,
>     > +                                   u32 arg3, u32 arg4)
>     > +{
>     > +       return -EPERM;
>     > +}
>     > +
>     >  #endif
>     
>     tcp_call_bpf_1arg() and tcp_call_bpf_4arg() unused for the time being?
> 
> Yes, I just thought I should add them for completeness. Should I remove them 
> until
> they are actually used?

Yeah, I think that would be preferred way.

Thanks again,
Daniel